Skip to content

fix: make GitHub skills shell-neutral across platforms#324

Open
jamiechicago312 wants to merge 5 commits into
OpenHands:mainfrom
jamiechicago312:fix/github-skills-cross-platform-323
Open

fix: make GitHub skills shell-neutral across platforms#324
jamiechicago312 wants to merge 5 commits into
OpenHands:mainfrom
jamiechicago312:fix/github-skills-cross-platform-323

Conversation

@jamiechicago312

Copy link
Copy Markdown
Member

Problem

GitHub-related skills in extensions still default to POSIX/bash-specific setup patterns. That makes Windows usage awkward even when the underlying workflows are otherwise cross-platform.

Scope

  • update github, github-pr-review, github-pr-reviewer, and github-repo-monitor
  • remove bash-only defaults like /tmp, heredocs, mkdir -p, tar -czf, and grep/sed-style verification from the primary guidance
  • prefer shell-neutral instructions, workspace-local JSON files, Python-based packaging, and guidance that adapts to the active shell
  • regenerate skills/index.js

Testing

  • uv run --with pytest --with requests --with openhands-sdk pytest tests/test_github_pr_review_skill.py tests/test_skills_have_readme.py tests/test_workflow_sync.py tests/test_sync_extensions.py

Closes #323.

This PR description was created by an AI agent (OpenHands) on behalf of the user.

Co-authored-by: openhands <openhands@all-hands.dev>
@jamiechicago312 jamiechicago312 changed the title [fix] make GitHub skills shell-neutral across platforms fix: make GitHub skills shell-neutral across platforms Jun 9, 2026
@github-actions github-actions Bot added the type: fix A bug fix label Jun 9, 2026
Co-authored-by: openhands <openhands@all-hands.dev>
@jamiechicago312 jamiechicago312 marked this pull request as ready for review June 11, 2026 15:21
Co-authored-by: openhands <openhands@all-hands.dev>
Comment thread skills/github-pr-review/README.md
Comment thread skills/github-pr-review/SKILL.md Outdated
Comment thread skills/github-pr-reviewer/SKILL.md Outdated
@neubig

neubig commented Jun 11, 2026

Copy link
Copy Markdown
Member

@OpenHands

  1. for the bigger python snippets, could we write them as scripts in the skill directory scripts folder? that would make them more immediately reusable.
  2. check enyst's review comments. if it would be possible to rely on the system temporary directory consistently that should be better.

@openhands-ai

openhands-ai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Uh oh! There was an unexpected error starting the job :(

@jamiechicago312

Copy link
Copy Markdown
Member Author
  • for the bigger python snippets, could we write them as scripts in the skill directory scripts folder? that would make them more immediately reusable.
  • check enyst's review comments. if it would be possible to rely on the system temporary directory consistently that should be better.

@OpenHands address these concerns by @neubig

@openhands-ai

openhands-ai Bot commented Jun 11, 2026

Copy link
Copy Markdown

I'm on it! jamiechicago312 can track my progress at all-hands.dev

Co-authored-by: openhands <openhands@all-hands.dev>

Copy link
Copy Markdown
Member Author

Addressed in a96c5a9:

  • restored a concrete example in skills/github-pr-review/README.md
  • switched the GitHub review/GraphQL temp-file guidance to system-temp placeholders
  • extracted the larger GitHub automation setup snippets into reusable helper scripts under skills/github-pr-reviewer/scripts/ and skills/github-repo-monitor/scripts/
  • updated the automation docs so generated tarballs/build artifacts live outside the repository

Validation: uv run --with pytest --with requests --with openhands-sdk pytest -q tests/test_github_pr_review_skill.py tests/test_skills_have_readme.py tests/test_workflow_sync.py tests/test_sync_extensions.py

This comment was created by an AI agent (OpenHands) on behalf of the user.

Co-authored-by: openhands <openhands@all-hands.dev>
@jamiechicago312

Copy link
Copy Markdown
Member Author

OK openhands resolved concerns from @neubig and @enyst 🙏 tysm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix]: make GitHub skills work cleanly on Windows, macOS, and Linux

4 participants